-
-
Notifications
You must be signed in to change notification settings - Fork 552
Update hyprpaper.md #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update hyprpaper.md #1105
Conversation
Add a check for mime-type in documentation for "Get a random wallpaper that is not the current one". This prevents hyprpaper from trying to load a .git directory, or other mime types and crashing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just keep shuffling until we find a good mimetype?
Optionally we could configure a maximum count and if we hit it without finding a mimetype, show the error. This way, the script does not run forever in case of failures.
|
fixed my whoops of changing original shebang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about --instance 0 being everywhere. I guess it should be noted above/below the script that if it is run in an environment without HIS present, it should be added.
| ATTEMPTS=0 | ||
| MAX_NUM=10 | ||
| FILES=() | ||
| WALLPAPER_DIR="/usr/share/backgrounds" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also looks weird. Should be left as the user's home.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sound feedback, I will get that updated when I can.
Add a check for mime-type in documentation for "Get a random wallpaper that is not the current one".
This prevents hyprpaper from trying to load a .git directory, or other mime types and crashing.