Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable NIP-17 Encrypted Direct Messages #244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aliraza556
Copy link

Problem:

  • Lack of support for NIP-17 encrypted direct messages, leading to missed communications.

closes: #237

Issue ticket number and link:

@aliraza556
Copy link
Author

Hi @Giszmo @hzrd149, Please review this PR.

Copy link

@Giszmo Giszmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look extremely clean and of high quality. I have not functionally tested the PR.

@aliraza556
Copy link
Author

The changes look extremely clean and of high quality. I have not functionally tested the PR.

@Giszmo Thank you! Glad to hear the feedback.

@Giszmo
Copy link

Giszmo commented Oct 2, 2024

I tried it out and cannot see the supposed 2 DMs I should have received. Neither can I see how that would be supposed to work when sending. Where is the logic where one method gets picked over the other and based on what?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable nip17 DMs
2 participants