feat: add opentelemetry collector #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Pilar <[email protected]>
Tomas2D
approved these changes
Dec 6, 2024
jezekra1
requested changes
Dec 6, 2024
| @@ -253,6 +254,11 @@ services: | |||
| ports: | |||
| - 19531:3000 | |||
| profiles: [ all, infra ] | |||
|
|
|||
There was a problem hiding this comment.
Please add it to the infra profile, we don't have a path or documentation for users to benefit from the collector so I don't want to take up extra memory and download time by this.
Or we could extract observe + mlflow + collector to as separate start:observe profile, most people don't need these by default
There was a problem hiding this comment.
we could extract observe + mlflow + collector to as separate start:observe profile
+1 like that idea a lot
|
Added in a separate PR, thanks for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.