Add Support for Waveshare ESP32-S3-LCD-1.47 board #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow thanks! I got my own Waveshare board last night and starting working on a similar port! I've got a few other changes I've added which i'll base on this PR. |
|
Will merge this if it builds and add PSRAM support later |
Very cool! I'm going to look into adding support for the Waveshare ESP32-S3-GEEK next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for your hard work on this awesome project.
This PR adds support for the Waveshare ESP32-S3-LCD-1.47, a board very similar to the LILYGO Dongle.
Additionally, it changes the
platformio.iniconfiguration to useextends = common, rather than redundantly listing the${common.<whatever>}options for each board.Finally, it moves the definition of the TFT panel type to the
platformio.inifileThese changes have been tested on the aforementioned Waveshare board. Thanks again!