Feature/389 login required #364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmenezes0
force-pushed
the
feature/389-login-required
branch
from
d67b3ce to
e30b0a9
Compare
nmenezes0
force-pushed
the
feature/389-login-required
branch
from
e30b0a9 to
39ebcb5
Compare
nmenezes0
force-pushed
the
feature/389-login-required
branch
from
39ebcb5 to
6fff21b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Default to all views requiring login unless declared otherwise.
Changes proposed in this pull request
Default to all views requiring login using the new functionality in Django 5.1. Safer to default to login required, than have to remember to manually add
@login_requiredto all views.Guidance to review
To test - check you can't access most pages if not logged in. Check if you aren't a "staff" user that you can't login to the support area.
Other questions:
login_not_requiredcorrect i.e. you should be able to access these pages without logging in?Link to JIRA ticket
https://technologyprogramme.atlassian.net/browse/CON-403
Things to check
.env.exampleand.env.testfiles in the repo