Bugfix/fe again #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fix error with not being able to run frontend in Docker. (This is background: https://stackoverflow.com/questions/72157321/docker-container-works-from-dockerfile-but-get-next-not-found-from-docker-compo)
Also remove the "version" statement at the top of the docker compose as we kept getting a warning about it not being needed.
frontend/next-env.d.tsis an autogenerated file by Next.js and should be committed to repo.Have run all tests (as per README) - and they all passed.
This PR contains:
Guidance to review
How could someone else check this work? Which parts do you want more feedback on?
Run
docker compose up --build- does frontend work?