add shift and unshift method

[tlayh]

• adding a shift and unshift function to pugtemplate
• added additional tests to existing functions

[tlayh]

@bastianccm The tests are only comparing the items parts of the array. Currently, the methods, also for pop and push, are not manipulating the interface part of the array. Is this fine like it is?

[bastianccm]

Hi @tlayh what do you mean by "Currently, the methods, also for pop and push, are not manipulating the interface part of the array. Is this fine like it is?"? Can you give an example?

[tlayh]

Hi @tlayh what do you mean by "Currently, the methods, also for pop and push, are not manipulating the interface part of the array. Is this fine like it is?"? Can you give an example?

Taking the unit test for unshift as an example, if I compare the the array instead of comparing the items of the array, the unit test fails with the following:

expected: &pugjs.Array{items:[]pugjs.Object{"first", "something", "test"}, o:[]string{"first", "something", "test"}}
actual : &pugjs.Array{items:[]pugjs.Object{"first", "something", "test"}, o:[]string{"something", "test"}}

The item part is correct, the o: part fails.

Does this help as an example

[bastianccm]

That is fine. o points to the original data the Object is created with, which usually can not be mutated.

Can you resolve the conflicts? Then we can merge it.

[tlayh]

That is fine. o points to the original data the Object is created with, which usually can not be mutated.

Can you resolve the conflicts? Then we can merge it.

Resolved.

[brnhffmnn]

This could even be shorter, couldn't it:

Suggested change

	a.items = a.items[1:len(a.items)]
	a.items = a.items[1:]

[tlayh]

Changed it. Unit tests are telling me that it is still working