PostgreSQL support #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eUploadStatus and deleteUploadData. It fixes the exception: org.postgresql.util.PSQLException: ERROR: syntax error at or near "{".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this pull request contains code for supporting PostgreSQL as i2b2 backend. Basically it completes db related if/else statements in CRC code adding lines for properly working with PostgreSQL.
The pull request also includes some modifications in UploadStatusDAO.dropTempTable method, dropping jdbcTemplate since it results in a a runtime org.postgresql.util.PSQLException.
I was not able to properly run tests, anyway in my environment I had the same failures/errors (mostly due to a connection refused problem) before and after the commits included in this pull request. If you can link some information about how to tests, I will be happy to verify that all tests pass.
I tested the pull request deploying an instance of i2b2 and uploading some pdo files.