Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added latest ALMA cycles configurations #634

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Added latest ALMA cycles configurations #634

merged 4 commits into from
Dec 18, 2024

Conversation

anawas
Copy link
Collaborator

@anawas anawas commented Dec 4, 2024

  • In the upcoming year 2025 the ALMA telescope (Atacama Large Microwave Array) offers three new dish configurations (called cycles). I added configuration files for these.
  • I also added the script which I used to convert the ALMA config files into OSKAR telescope configurations. It can be used both to convert further cycles, and update past cycles.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.19%. Comparing base (420469a) to head (0780612).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
+ Coverage   71.03%   71.19%   +0.15%     
==========================================
  Files          55       55              
  Lines        5914     5946      +32     
==========================================
+ Hits         4201     4233      +32     
  Misses       1713     1713              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mpluess mpluess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions, looks good otherwise!

karabo/data/_add_oskar_alma_layouts/README.md Outdated Show resolved Hide resolved
karabo/data/_add_oskar_alma_layouts/README.md Show resolved Hide resolved
Copy link
Member

@mpluess mpluess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anawas anawas merged commit 30fa377 into main Dec 18, 2024
3 checks passed
@anawas anawas deleted the aw_add_alma_cycles branch December 18, 2024 11:05
anawas added a commit that referenced this pull request Dec 18, 2024
* Scripts fetches and converts ALMA config files into OSKAR files 📟

* Latest configs for ALMA cycles 9, 10, 11 🚑

* Resolved type conflict (was complained about by mypy) 😕

* Updated documentation as suggested in comments to PR #634 ♍

* Adding link to Karabo workshop on Renkulab 📃

* Section 'Show telescope config' belongs to basic examples :rage3:

* Revert "Section 'Show telescope config' belongs to basic examples :rage3:". The changes were made in the wrong file.

This reverts commit 50e885f.

* Moved section up because it's of general interest and not only SRC related. 🍕

* Fixed more formatting issues 📁

* Added module descriptions 👶

* Fixed formatting issues 👅

* Rewritten docu for imaging module 🚻

* Added a link in README and documentation to the Karabo Workshop on Renkulab ⚡

* Added note to limited server resources on Renkulab.
anawas added a commit that referenced this pull request Dec 20, 2024
* Scripts fetches and converts ALMA config files into OSKAR files 📟

* Latest configs for ALMA cycles 9, 10, 11 🚑

* Resolved type conflict (was complained about by mypy) 😕

* Updated documentation as suggested in comments to PR #634 ♍

* Adding link to Karabo workshop on Renkulab 📃

* Section 'Show telescope config' belongs to basic examples :rage3:

* Revert "Section 'Show telescope config' belongs to basic examples :rage3:". The changes were made in the wrong file.

This reverts commit 50e885f.

* Moved section up because it's of general interest and not only SRC related. 🍕

* Fixed more formatting issues 📁

* Added module descriptions 👶

* Fixed formatting issues 👅

* Rewritten docu for imaging module 🚻

* Added a link in README and documentation to the Karabo Workshop on Renkulab ⚡

* Added note to limited server resources on Renkulab.

* Added 'napoleon' extension. This renders  Google docstyle properly. 💗

* Added docu for WSClean imager (as requested) 💃

* Switched to Google docstring wherever possible. 🌚
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants