Add support for trigger scaling in compression mode S=0,k=0,M=7 #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaloney
force-pushed
the
feat-trigger-scaling
branch
from
9a5e793
to
89ae5ee
Compare
|
This will need to be rebased on #375 once merged to fix the CI tests. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #377 +/- ##
==========================================
- Coverage 77.79% 76.81% -0.99%
==========================================
Files 65 66 +1
Lines 6777 6900 +123
==========================================
+ Hits 5272 5300 +28
- Misses 1505 1600 +95 ☔ View full report in Codecov by Sentry. |
samaloney
force-pushed
the
feat-trigger-scaling
branch
from
45c8f80
to
71771aa
Compare
* QL - LC, BKG, SPECTRA * BSD - CPD, SCPD, VIS and SPEC
samaloney
force-pushed
the
feat-trigger-scaling
branch
from
11f8ef9
to
e5258f7
Compare
nicHoch
requested changes
Dec 15, 2023
samaloney
force-pushed
the
feat-trigger-scaling
branch
from
2ecddcc
to
49402c0
Compare
samaloney
force-pushed
the
feat-trigger-scaling
branch
from
49402c0
to
b31c64a
Compare
|
Not to sure about the E2E test fails not related but wasn't expecting them either ... |
nicHoch
approved these changes
Dec 19, 2023
|
Yea well I was able to produce fits files, I tried to compare the triggers from the QL lightcurve, background and spectra and they didn't match but hard to know if they should based on the different detector masks etc so until we get real data not much more can be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unscale trigger data when compressed with mode S=0,k=0,M=7
When compressed with mode 0,0,7 the trigger are scaled by the FSW according to
T_s = T / (n_int * n_acc * factor)this scaling is removed by the GSW.Closes #365