Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daily processing pipeline #405

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

nicHoch
Copy link
Collaborator

@nicHoch nicHoch commented Oct 17, 2024

create a second processing pipeline to handle not TM packets triggered processing steps

this pipeline runs on a cron bases (once a day?) and performs product creations (fits files)

first included processing is HK-L+ to ANC-ASPECT files

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 6.10413% with 523 lines in your changes missing coverage. Please review.

Project coverage is 71.52%. Comparing base (817c558) to head (c3f3b5d).

Files with missing lines Patch % Lines
stixcore/processing/pipeline_daily.py 0.00% 132 Missing ⚠️
stixcore/processing/SingleStep.py 0.00% 94 Missing ⚠️
stixcore/processing/AspectANC.py 0.00% 78 Missing ⚠️
stixcore/io/FlareListManager.py 0.00% 74 Missing ⚠️
stixcore/io/FlareListProductsStorage.py 0.00% 66 Missing ⚠️
stixcore/processing/FLtoL3.py 0.00% 66 Missing ⚠️
stixcore/io/fits/processors.py 28.57% 10 Missing ⚠️
stixcore/ephemeris/manager.py 88.88% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
- Coverage   75.83%   71.52%   -4.31%     
==========================================
  Files          68       74       +6     
  Lines        7254     7678     +424     
==========================================
- Hits         5501     5492       -9     
- Misses       1753     2186     +433     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicHoch nicHoch added this to the v1.5.0 milestone Nov 5, 2024
Copy link
Collaborator

@samaloney samaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

I'm concerned about out use of context mangers and multiple threads - I don't think they are natively thread aware. Might not be an issue for this PR but brought to my attention based on our conversation the other day and this PR

# self.cur.execute('''CREATE INDEX if not exists processed_flare_products_idx ON
# processed_flare_products (flareid, flarelist, version, name,
# level, type)''')

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be uncommented?

Comment on lines +136 to +139
if __name__ == '__main__':
flm = SDCFlareListManager(Path("./flarelist.scv"), update=False)
print(flm)
print(flm.flarelist)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if __name__ == '__main__':
flm = SDCFlareListManager(Path("./flarelist.scv"), update=False)
print(flm)
print(flm.flarelist)

@@ -30,6 +30,7 @@ install_requires =
sunpy>=4.0.1
watchdog
requests
stixdcpy @ git+ssh://[email protected]/i4ds/stixdcpy.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a tag or version we can set here? This will just install what ever is on master

@samaloney
Copy link
Collaborator

Also I see the tests are failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants