Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary network reset #186

Merged
merged 4 commits into from
Feb 12, 2025
Merged

Remove unnecessary network reset #186

merged 4 commits into from
Feb 12, 2025

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented Feb 12, 2025

No description provided.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (0db31c3) to head (5af09f8).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #186   +/-   ##
========================================
  Coverage    84.50%   84.50%           
========================================
  Files           35       35           
  Lines         1084     1084           
  Branches       221      221           
========================================
  Hits           916      916           
  Misses         168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zguesmi zguesmi marked this pull request as ready for review February 12, 2025 13:49
@zguesmi zguesmi self-assigned this Feb 12, 2025
Copy link

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes me think that it could be a good idea to introduce Zod for environment validation, just like we did for the voucher repo.

scripts/hardhat-fixture-deployer.ts Outdated Show resolved Hide resolved
scripts/hardhat-fixture-deployer.ts Outdated Show resolved Hide resolved
@Le-Caignec Le-Caignec self-requested a review February 12, 2025 14:21
Copy link
Member

@jeremyjams jeremyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

* @param contractName contract name to deploy
* @param deployedAddress address where contract where deployed
*/
function saveDeployedAddress(contractName: string, deployedAddress: string) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we all good in poco-chain?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have already checked that we break nothing in:

But I should note that some cleaning has to be done in poco-chain project, I created an issue with the required details: https://github.com/iExecBlockchainComputing/poco-chain/issues/25

@zguesmi
Copy link
Member Author

zguesmi commented Feb 12, 2025

This PR makes me think that it could be a good idea to introduce Zod for environment validation, just like we did for the voucher repo.

It's a good idea, however, I'd rather keep it for a separate PR.

@zguesmi zguesmi merged commit 52eef1d into develop Feb 12, 2025
5 checks passed
@zguesmi zguesmi deleted the feature/fixture-cleaning branch February 12, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants