Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate deployments scripts to Ethers v6 #187

Merged

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented Feb 12, 2025

npx hardhat deploy output:

Deploying PoCo..
→ Factory is not yet deployed on this network
RLC: 0x5FbDB2315678afecb367f032d93F642f64180aa3
→ Factory successfully deployed
ERC1538UpdateDelegate: 0xD9b55D80c9B7065Ad7EB0A0105ce4512221d9ded
ERC1538Proxy: 0x0C8Da709368Cf0C1645837658490Dc322e21ca32
IexecInstance found at address: 0x0C8Da709368Cf0C1645837658490Dc322e21ca32
[Warning] Invalid Fragment {"inputs":[{"components":[{"components":[{"internalType":"address","name":"app","type":"address"},{"internalType":"uint256","name":"appmaxprice","type":"uint256"},{"internalType":"address","name":"dataset","type":"address"},{"internalType":"uint256","name":"datasetmaxprice","type":"uint256"},{"internalType":"address","name":"workerpool","type":"address"},{"internalType":"uint256","name":"workerpoolmaxprice","type":"uint256"},{"internalType":"address","name":"requester","type":"address"},{"internalType":"uint256","name":"volume","type":"uint256"},{"internalType":"bytes32","name":"tag","type":"bytes32"},{"internalType":"uint256","name":"category","type":"uint256"},{"internalType":"uint256","name":"trust","type":"uint256"},{"internalType":"address","name":"beneficiary","type":"address"},{"internalType":"address","name":"callback","type":"address"},{"internalType":"string","name":"params","type":"string"},{"internalType":"bytes32","name":"salt","type":"bytes32"},{"internalType":"bytes","name":"sign","type":"bytes"}],"internalType":"struct IexecLibOrders_v5.RequestOrder","name":"order","type":"tuple"},{"internalType":"enum IexecLibOrders_v5.OrderOperationEnum","name":"operation","type":"IexecLibOrders_v5.OrderOperationEnum"},{"internalType":"bytes","name":"sign","type":"bytes"}],"internalType":"struct IexecLibOrders_v5.RequestOrderOperation","name":"_requestorderoperation","type":"tuple"}],"name":"hash","outputs":[{"internalType":"bytes32","name":"","type":"bytes32"}],"stateMutability":"pure","type":"function"}: invalid type (argument="type", value="IexecLibOrders_v5.OrderOperationEnum", code=INVALID_ARGUMENT, version=6.13.5)

[...]

AppRegistry: 0xeF4a99201Efa1B02Dc893fDAdccEf06D420b1eF8
DatasetRegistry: 0xE3A0a4ff11d5019F48d78c2F094810844d2e3e1f
WorkerpoolRegistry: 0x01b380a687A2B0CD730dbC72557CEae074246e87
countCategory is now: 5 (was 0)
Category 0: XS,{},300
Category 1: S,{},1200
Category 2: M,{},3600
Category 3: L,{},10800
Category 4: XL,{},36000
Deploying and configuring ENS..
ENSRegistry: 0xb7278A61aa25c888815aFC32Ad3cC52fF24fE575
PublicResolver: 0xCD8a1C3ba11CF5ECfa6267617243239504a98d90
ReverseRegistrar: 0x82e01223d51Eb87e16A03E24687EDF0F294da6f1
FIFSRegistrar for domain : 0x2bdCC0de6bE1f7D2ee689a0342D76F52E8EFABa3
FIFSRegistrar for domain eth: 0xFD471836031dc5108809D173A067e8486B9047A3
FIFSRegistrar for domain iexec.eth: 0x1429859428C0aBc9C2C47C8Ee9FBaf82cFA0F20f
FIFSRegistrar for domain v5.iexec.eth: 0x162A433068F51e18b7d13932F27e66a3f99E6890
FIFSRegistrar for domain users.iexec.eth: 0x5081a39b8A5f0E35a8D959395a630b68B74Dd30f
FIFSRegistrar for domain apps.iexec.eth: 0xdbC43Ba45381e02825b14322cDdd15eC4B3164E6
FIFSRegistrar for domain datasets.iexec.eth: 0x4C4a2f8c81640e47606d3fd77B353E87Ba015584
FIFSRegistrar for domain pools.iexec.eth: 0x2E2Ed0Cfd3AD2f1d34481277b3204d807Ca2F8c2

Diff with old logs:
image

@zguesmi zguesmi changed the title Feature/hardhat and ethers upgrade part1 Migrate deployments scripts to Ethers v6 Feb 12, 2025
Copy link

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zguesmi zguesmi marked this pull request as ready for review February 13, 2025 11:15
@zguesmi zguesmi self-assigned this Feb 13, 2025
Copy link
Member

@jeremyjams jeremyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks 👍 !

@zguesmi zguesmi merged commit 20cd559 into feature/migration-to-ether-v6 Feb 13, 2025
1 check failed
@zguesmi zguesmi deleted the feature/hardhat-and-ethers-upgrade-part1 branch February 13, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants