feature/migrate-utils-to-ethers6 #188
Closed
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Le-Caignec
changed the title
Le-Caignec
changed the base branch from
feature/migration-to-ether-v6
to
feature/hardhat-and-ethers-upgrade-part1
…de-part1' into feature/migrate-utils-to-ethers6
…for various scripts and utility files
Base automatically changed from
feature/hardhat-and-ethers-upgrade-part1
to
feature/migration-to-ether-v6
February 13, 2025 16:58
…nto feature/migrate-utils-to-ethers6
zguesmi
reviewed
Feb 14, 2025
| @@ -292,7 +292,7 @@ export async function signOrder( | |||
| domain: TypedDataDomain, | |||
| order: Record<string, any>, | |||
| signer: SignerWithAddress, | |||
| ): Promise<void> { | |||
| ): Promise<Record<string, any>> { | |||
There was a problem hiding this comment.
It should be compatible with the signStruct function, which does not return a void Promise.
signStruct(primaryType: string, message: Record<string, any>, domain: TypedDataDomain, wallet: WalletInfo): Promise<Record<string, any>>
There was a problem hiding this comment.
I don't see the return values of signStruct, signOrder, signOrderOperation used anywhere.
I think we need to refactor these functions to either make them pure or remove the return value. Ofc not necessarily for this PR.
Le-Caignec
commented
Feb 14, 2025
| if (split.v == 1 || split.v == 28) { | ||
| const split = ethers.Signature.from(signature); | ||
| let vs = ethers.getBytes(split.s); | ||
| if (split.v == 27 || split.v == 28) { |
There was a problem hiding this comment.
I'm not sure to understand here why we need to replace 1 by 27. To be validated !
There was a problem hiding this comment.
It seems that signature.v is the legacy method and signature.yParity is the new method.
But we should be careful before changing it and check first if we need to support legacy signatures.
jeremyjams
reviewed
Feb 14, 2025
Co-authored-by: Zied Guesmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.