Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract asset address from receipt #191

Merged

Conversation

jeremyjams
Copy link
Member

No description provided.

Copy link
Member

@zguesmi zguesmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, well done!

test/utils/IexecWrapper.ts Show resolved Hide resolved
txReceipt: ContractTransactionReceipt,
address: string,
contractInterface: Interface,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious whether we can use just the ABI of the event (Fragment) instead of all the contract's interface.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ABI of the event would we totally fine yes 👍

Copy link

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gfournieriExec gfournieriExec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work :)

@jeremyjams jeremyjams merged commit 378aac9 into feature/migration-to-ether-v6 Feb 17, 2025
1 check passed
@jeremyjams jeremyjams deleted the feature/asset-address-from-receipt branch February 17, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants