Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/add types checking #53

Merged
merged 11 commits into from
Jan 15, 2025
Merged

feature/add types checking #53

merged 11 commits into from
Jan 15, 2025

Conversation

Le-Caignec
Copy link

No description provided.

@Le-Caignec Le-Caignec self-assigned this Dec 27, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.30%. Comparing base (c53352d) to head (ed7037e).
Report is 12 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop      #53   +/-   ##
========================================
  Coverage    99.30%   99.30%           
========================================
  Files            4        4           
  Lines          286      286           
  Branches        53       53           
========================================
  Hits           284      284           
  Misses           2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Le-Caignec Le-Caignec requested review from a team and removed request for a team January 2, 2025 10:32
gfournieriExec
gfournieriExec reviewed Jan 2, 2025
View reviewed changes
tsconfig.json Outdated Show resolved Hide resolved
@gfournieriExec gfournieriExec mentioned this pull request Jan 2, 2025
Open
2 tasks
@Le-Caignec Le-Caignec requested a review from a team January 10, 2025 12:21
@Le-Caignec Le-Caignec marked this pull request as ready for review January 10, 2025 12:21
gfournieriExec
gfournieriExec approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@gfournieriExec gfournieriExec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

CHANGELOG.md Outdated Show resolved Hide resolved
@Le-Caignec Le-Caignec requested a review from a team January 13, 2025 09:09
jeremyjams
jeremyjams reviewed Jan 13, 2025
View reviewed changes
scripts/common.ts Outdated Show resolved Hide resolved
zguesmi
zguesmi reviewed Jan 13, 2025
View reviewed changes
scripts/common.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add 2025 to

// SPDX-FileCopyrightText: 2024-2025 IEXEC BLOCKCHAIN TECH <[email protected]>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And other modified files also.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit: 3353d22

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update other files: hardhat.config.ts, VoucherHub.test.ts, Voucher.test.ts

Copy link
Author

@Le-Caignec Le-Caignec Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix #62
Sorry i miss that before merging. But fix ✅

jeremyjams
jeremyjams approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@jeremyjams jeremyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@Le-Caignec Le-Caignec merged commit 89da050 into develop Jan 15, 2025
4 checks passed
@Le-Caignec Le-Caignec deleted the feature/add-types-checking branch January 15, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyjams jeremyjams jeremyjams approved these changes

@zguesmi zguesmi zguesmi left review comments

@gfournieriExec gfournieriExec gfournieriExec approved these changes

Assignees

@Le-Caignec Le-Caignec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Le-Caignec @zguesmi @jeremyjams @gfournieriExec