Feature/add js linter #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Le-Caignec
commented
Feb 4, 2025
•
Le-Caignec
commented
- fix solhint config Issue avec ici
- ajout d'un linter basic pour JS +TS
…proving readability
… improved readability
…ation for improved code quality
…uration to ignore .solcover.js file
zguesmi
reviewed
Feb 4, 2025
gfournieriExec
approved these changes
Feb 5, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #67 +/- ##
========================================
Coverage 99.30% 99.30%
========================================
Files 4 4
Lines 287 287
Branches 53 53
========================================
Hits 285 285
Misses 2 2 ☔ View full report in Codecov by Sentry. |
zguesmi
reviewed
Feb 6, 2025
jeremyjams
approved these changes
Feb 6, 2025
| @@ -13,8 +17,6 @@ | |||
| "quotes": [ | |||
| "error", | |||
| "double" | |||
| ], | |||
| "imports-order": "warn", | |||
There was a problem hiding this comment.
How import order warning got away since imports did not change in contracts?
There was a problem hiding this comment.
yes, I'm very confused too. I don't understand also 😵💫
Co-authored-by: Zied Guesmi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.