Remove introspection_endpoint from required secrets

The field is not mandatory and some OIDC providers (such as Nextcloud) don't provide it resulting in a key error. Also, refactored client secrets to use json.dumps() for better code readibility. Signed-off-by: Marek Pikuła <[email protected]>
iFargle · Apr 2, 2023 · df6f337 · df6f337
1 parent 87d39e8
commit df6f337
Showing 1 changed file with 12 additions and 14 deletions.
diff --git a/server.py b/server.py
@@ -55,21 +55,19 @@
     oidc_info = response.json()
     app.logger.debug("JSON Dumps for OIDC_INFO:  "+json.dumps(oidc_info))
 
-    client_secrets = """{
-        "web": {
-            "issuer": \""""+oidc_info["issuer"]+"""\",
-            "auth_uri": \""""+oidc_info["authorization_endpoint"]+"""\",
-            "client_id": \""""+OIDC_CLIENT_ID+"""\",
-            "client_secret": \""""+OIDC_SECRET+"""\",
-            "redirect_uris": [
-                \""""+DOMAIN_NAME+BASE_PATH+"""/oidc_callback"
-            ],
-            "userinfo_uri": \""""+oidc_info["userinfo_endpoint"]+"""\", 
-            "token_uri": \""""+oidc_info["token_endpoint"]+"""\",
-            "token_introspection_uri": \""""+oidc_info["introspection_endpoint"]+"""\"
+    client_secrets = json.dumps(
+        {
+            "web": {
+                "issuer": oidc_info["issuer"],
+                "auth_uri": oidc_info["authorization_endpoint"],
+                "client_id": OIDC_CLIENT_ID,
+                "client_secret": OIDC_SECRET,
+                "redirect_uris": [DOMAIN_NAME + BASE_PATH + "/oidc_callback"],
+                "userinfo_uri": oidc_info["userinfo_endpoint"],
+                "token_uri": oidc_info["token_endpoint"],
+            }
         }
-    }
-    """
+    )
 
     with open("/app/instance/secrets.json", "w+") as secrets_json:
         secrets_json.write(client_secrets)