Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate MuonCollider changes and updates back to iLCSoft #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Jun 6, 2024

BEGINRELEASENOTES

  • Add the DDCaloDigi_BIB that has been implemented by the muon collider community for their studies and has been used for some studies there already
  • Make it possible to do non-linearity corrections also for the ECAL in Pandora

ENDRELEASENOTES

Includes the changes in #28

@madbaron FYI, please add whoever should be added here for further discussion.

@madbaron
Copy link

madbaron commented Jun 6, 2024

Adding @sestini88, who I think is the author of DDCaloDigi_BIB (or might know who to add).

We might want to keep DDCaloDigi_BIB out of this PR.

It is definitely useful if we want to document historical/current studies, but the RealisticCaloDigi processors will generally be picked up by the community in going forward for SiW calos.

Dedicated work for crystal calorimetry is probably based on this processor and updates (Lorenzo certainly knows more than me here), so perhaps the processor could use a renaming to make it more discoverable.
In the medium term, we should also figure out if there is any fundamental reason not to merge the crystal calorimeters work into RealisticCaloDigi instead.

@tmadlener
Copy link
Contributor Author

I have moved the ECAL corrections into #28 which we can now probably merge a bit quicker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants