Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warnings and change LCIO_LIBRARIES to LCIO::lcio #53

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix compiler warnings and change LCIO_LIBRARIES to LCIO::lcio #53

wants to merge 5 commits into from

Conversation

jmcarcell
Copy link
Contributor

@jmcarcell jmcarcell commented Jan 15, 2024 •
edited
Loading

BEGINRELEASENOTES

  • Fix a warning about using namespace in headers and a few other warnings
  • Change LCIO_LIBRARIES to LCIO::lcio

ENDRELEASENOTES

These changes are not trivial since repositories like k4MarlinWrapper depending on Marlin will have to be updated too.

@jmcarcell jmcarcell mentioned this pull request Feb 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmcarcell