Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that code formatting conforms to Key4hep formatting defaults #70

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Aug 21, 2024

BEGINRELEASENOTES

  • Add the .clang-format default file that is also used by other Key4hep repositories
  • Add a basic pre-commit configuration to run formatting checks
  • Run clang-format to fix all formatting issues

ENDRELEASENOTES

@tmadlener
Copy link
Contributor Author

Re-ordering includes by clang-format uncovered an issue in a Marlin header file. See iLCSoft/Marlin#58

@tmadlener
Copy link
Contributor Author

The workflows that are still failing haven't picked up the necessary fix in Malrlin (iLCSoft/Marlin#58) yet.

@tmadlener tmadlener merged commit 32b5a3e into iLCSoft:master Aug 23, 2024
4 of 7 checks passed
@tmadlener tmadlener deleted the format-repo branch August 23, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant