Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/design tweaks #190

Merged
merged 41 commits into from
Jul 20, 2016
Merged

Feature/design tweaks #190

merged 41 commits into from
Jul 20, 2016

Conversation

xavez
Copy link
Member

@xavez xavez commented Jul 20, 2016 •
edited
Loading

This PR contains

  • A new design for the homepage
  • Restructured scss files
  • Swapped some custom css for default bootstrap css
  • Removed a bunch of unnecessary css (see main.scss)
  • Improved Grunt workflow

New homepage design

  • A lot of tiny accessibility improvements like fast keyboard use and proper linking of labels to inputs
  • Removed confusing live-board button inside input fields. People should use the "find station" button.
  • Simplified depart / arrive settings for people who just want to leave now
  • Bigger touch targets for autocomplete forms

This PR also fixes #186 #169

xavez added 30 commits July 19, 2016 11:31
@xavez
Planner: properly link labels
ac6fc91
@xavez
Update planner view, WIP
efd5f0b
@xavez
Merge branch 'feature/fix-concat-task' into feature/design-tweaks
01bf075 
* feature/fix-concat-task:
  Fix concat task
@xavez
FR: ' -> ’
1713047
@xavez
EN: Simpler copy from/to
ae3f0c4
@xavez
Update sass/compass dependencies
ef5e890
@xavez
Fix navbar logo flow
def18a8
@xavez
Ignore .map sourcemaps files
9cfd06a
@xavez
Enable sourcemaps for scss
da5fa0b
@xavez
Remove unused scss file
0d0bd47
@xavez
Clean up some css
bd8fa0a
@xavez
Remove concat task for css
83d6a45
@xavez
Make dropdown more usable
b4ae770
@xavez
Better dropdown component
2b8f3a2
@xavez
Remove harmful disabling of scaling by user
c581047
@xavez
Experiment: use stations as placeholder text
c128549
@xavez
Turn off autocorrect on input fields
07ebd5c
@xavez
Accessibility tweaks for dropdown
6916db4
@xavez
No more border radius
be580b3
@xavez
Datepicker: start on Monday, fixes iRail#169
fc5f7ed
@xavez
checkpoint commit
1bc587c
@xavez
More UI tweaks
5e5c129
@xavez
Homepage: more friendly design
a787a51
@xavez
Hide liveboard in route planner
04e917d
@xavez
Fix bug in French translation
24af013
@xavez
Exclude storage/debugbar
4cf790c
@xavez
Footer: use muted text
e207355
@xavez
Nicer inputs for station selection
1f713b6
@xavez
Bring all text in line
9aa809a
@xavez
Small copy tweaks
58ddad9
@xavez xavez mentioned this pull request Jul 20, 2016
Closed
@pietercolpaert
Copy link
Member

Thanks @xavez! The iRail main page certainly looks way more beautiful now!

@pietercolpaert pietercolpaert merged commit 55962f3 into iRail:master Jul 20, 2016
@xavez
Copy link
Member Author

xavez commented Jul 20, 2016

@pietercolpaert seems like the CSS / JS didn’t regenerate though?

@pietercolpaert
Copy link
Member

Hmmm... Anything I could have forgotten? Aren't the build files added in the repo anymore?

@xavez
Copy link
Member Author

xavez commented Jul 20, 2016

They still are . . . maybe run the grunt task manually?

@pietercolpaert
Copy link
Member

Fixed: was cache error

@xavez xavez deleted the feature/design-tweaks branch July 21, 2016 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why are there two Sass source folders?
2 participants
@xavez @pietercolpaert