Assorted fixes for the AggregatedDotPlot class. #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the application from choking when it is asked to cluster too many rows, e.g., because the user was careless in the table filtering used to generate the multiple selection. Besides, there's no point making a dot plot where you can't even identify the genes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some implications for iSEE core that I don't have time to fix myself but someone might want to have a look at:
.multiSelectionResponsive()method for allPanels. Some default method would be helpful, possibly just returningTRUEand leaving it to subclasses to optimize. (Cleaned up .multiSelectionResponsive code and documentation. iSEE#684)dimsin?.multiSelectionResponsivedocs are not mentioned. This is a character vector containing either, both or none of"row"and"column", depending on the types of transmitted selections. (Cleaned up .multiSelectionResponsive code and documentation. iSEE#684).extractAssaySubmatrix(), so that (i) the same general idea can be used forComplexHeatmapPlot, and (ii) we get better memory efficiency by doinghead()on.chosen.rowsbefore coercing the matrix to a dense form.