Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1779: Showing month in HeaderView calendar #1780

Closed

Conversation

kalina559
Copy link
Collaborator

Solves #1779. Not sure about this one though, it could be useful when scrolling a long way back in the Header View calendar, but it basically shows the same thing for every day of the month. Below is the comparison of the current app (1), the code in this pull request (2) and a third option that would show the month only for first/last day of the month (3). Please let me know which one makes the most sense for you.

MicrosoftTeams-image (22)

MicrosoftTeams-image (23)

MicrosoftTeams-image (24)

@kalina559
Copy link
Collaborator Author

@iSoron @hiqua I know a lot of tests started failing now, but before I fix them let me know if this change makes sense :)

@hiqua
Copy link
Collaborator

hiqua commented Jul 30, 2023

The main drawback is that it takes more space, so you can visualize less habits at the same time. Maybe that's fine though? Wondering if we could have the month on the same row as the date instead. I don't have a strong opinion on this though, so fine for me. @iSoron?

P.S.: for next time, if you could have screenshots in English, that'd make it easier to have an idea of what your changes do!

@hiqua hiqua removed their assignment Aug 10, 2023
@iSoron
Copy link
Owner

iSoron commented Jan 31, 2024

Thanks for the PR, @kalina559. I'm not a huge fan of this layout as (i) it occupies more space; (ii) the month row will show the same text repeatedly, in the vast majority of situations. I agree that it would be nice to display the month sometimes, but I suggest doing what we currently do for the charts: on January 1, 2024, for example, we could show "Jan \ 1" instead of "Monday \ 1".

@iSoron iSoron closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants