Added Streaks info for numeric habits #2059
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any SLA for getting review from maintainers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implemented the feature discussed in #1114. This feature shows streak chart aka "Best Streaks" for numerical habits as well. Only the days which met the target will be considered as streak.
Testing:
Verified both Numerical and YesOrNo is working as expected. Verified both streak and non-streaks are working as expected.
Sidenote:
This is my first contribution to any open source project. Also this is my first time working on Kotlin. Thereby please feel free to provide your tips, comments and suggestions.