Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(ElevationLayer): add visible property. #1769

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feature(ElevationLayer): add visible property. #1769

wants to merge 1 commit into from

Conversation

gchoqueux
Copy link
Contributor

Description

Add visible property to ElevationLayer.
If visible is false the elevation terrain is removed.
The bbox tile is updated too.

Screenshots

Capture

chrome-capture

@gchoqueux gchoqueux added the feature 🍏 Adds a new feature label Dec 13, 2021
@gchoqueux gchoqueux added this to the 2.37.0 milestone Dec 13, 2021
@mgermerie
Copy link
Contributor

It is necessary to re-position the camera when switching visible property, both in GlobeControls and PlanarControls. This should prevent having the camera under the ground in some cases, when switching visible to true.

@gchoqueux gchoqueux force-pushed the visible_elevation branch 2 times, most recently from 932c703 to a64b81a Compare December 16, 2021 15:23
@mgermerie
Copy link
Contributor

Maybe you could call the Controls update when visible property is changed, not only in the GUI tools ?

@gchoqueux gchoqueux modified the milestones: 2.37.0, 2.38.0 Feb 8, 2022
@gchoqueux gchoqueux modified the milestones: 2.38.0, 2.xx.x Apr 13, 2022
@mgermerie mgermerie marked this pull request as draft October 20, 2022 09:11
@jailln jailln marked this pull request as ready for review October 4, 2024 07:29
@jailln jailln requested a review from Desplandis October 4, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgermerie mgermerie mgermerie approved these changes

@Desplandis Desplandis Awaiting requested review from Desplandis

Assignees

@mgermerie mgermerie

Labels
feature 🍏 Adds a new feature
Projects
None yet
Milestone
2.xx.x
Development

Successfully merging this pull request may close these issues.
2 participants
@gchoqueux @mgermerie