Cloud Optimised Point Cloud (COPC) support #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Desplandis
force-pushed
the
qb/copc
branch
2 times, most recently
from
987b281 to
ef04ac4
Compare
Desplandis
changed the title
|
This PR is still missing some unit tests but is ready for review. |
Desplandis
force-pushed
the
qb/copc
branch
2 times, most recently
from
3e15e58 to
4792205
Compare
jogarnier
approved these changes
Aug 3, 2023
mgermerie
reviewed
Aug 3, 2023
mgermerie
reviewed
Aug 4, 2023
There was a problem hiding this comment.
Thanks for this PR !
I only have a few comments and two general remarks :
- Could you add yourself to CONTRIBUTORS.md ?
- I looked at coverage reports, and strangely some parts are not covered even if you call them in your new unit tests (the constructor of
CopcLayerfor instance). Could you take a look at it ? and add tests if needed ?
Other than that it should be good for me !
Desplandis
force-pushed
the
qb/copc
branch
5 times, most recently
from
8f78f6d to
c275bcd
Compare
Desplandis
force-pushed
the
qb/copc
branch
4 times, most recently
from
cf6c537 to
1cf17b1
Compare
Desplandis
force-pushed
the
qb/copc
branch
2 times, most recently
from
c0a2cde to
64a3f01
Compare
Desplandis
force-pushed
the
qb/copc
branch
2 times, most recently
from
46b0727 to
05a94db
Compare
Desplandis
added a commit
to Desplandis/demo-lidar
that referenced
this pull request
Feb 13, 2024
This demonstrator is based on iTowns 2.42 with some preview functionnalities: - support of COPC datasets (iTowns/itowns#2110) - support of more LAS attributes (iTowns/itowns#2262) - support of workers for LAS-based format (i.e. EPT, COPC)
Desplandis
added a commit
to Desplandis/itowns-starter-webpack
that referenced
this pull request
Feb 13, 2024
This demonstrator is based on iTowns 2.42 with some preview functionnalities: - support of COPC datasets (iTowns/itowns#2110) - support of more LAS attributes (iTowns/itowns#2262) - support of workers for LAS-based format (i.e. EPT, COPC)
Desplandis
added a commit
to Desplandis/demo-lidar
that referenced
this pull request
Feb 13, 2024
This demonstrator is based on iTowns 2.42 with some preview functionnalities: - support of COPC datasets (iTowns/itowns#2110) - support of more LAS attributes (iTowns/itowns#2262) - support of workers for LAS-based format (i.e. EPT, COPC)
Desplandis
added a commit
to Desplandis/demo-lidar
that referenced
this pull request
Feb 26, 2024
This demonstrator is based on iTowns 2.42 with some preview functionnalities: - support of COPC datasets (iTowns/itowns#2110) - support of more LAS attributes (iTowns/itowns#2262) - support of workers for LAS-based format (i.e. EPT, COPC)
AnthonyGlt
reviewed
Feb 29, 2024
AnthonyGlt
reviewed
Mar 4, 2024
| this.header = metadata.header; | ||
| this.info = metadata.info; | ||
| this.eb = metadata.eb; | ||
| // TODO: use wkt definition in `metadata.wkt` to infer/define crs |
There was a problem hiding this comment.
Is it planned (issue/proposal/PR link) ?
There was a problem hiding this comment.
Not for now, we let the user set the crs manually. We would need to have proj4 expose its wkt-parsing ability.
|
That would be a great feature :) |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support of COPC format:
CopcSourceandCopcLayerwhich extends existingPointCloudLayer.laz-perf.wasmby default through a CDN but this could be override by the user.Note that this PR does not:
Screenshots
Autzen Stadium
SoFI Stadium