Rework test functional #2179
Merged
Rework test functional #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftoromanoff
force-pushed
the
reworkTestFunctional
branch
4 times, most recently
from
2472956 to
2328132
Compare
ftoromanoff
force-pushed
the
reworkTestFunctional
branch
3 times, most recently
from
6a194b7 to
c3b1d5d
Compare
ftoromanoff
force-pushed
the
reworkTestFunctional
branch
from
c3b1d5d to
51aae20
Compare
jailln
reviewed
Feb 28, 2024
test/functional/hooks_functional.js
Outdated
| @@ -239,7 +263,7 @@ exports.mochaHooks = { | |||
| ); | |||
| view.controls.lookAtCoordinate(init, false); | |||
| view.notifyChange(); | |||
| } else if (view.isPlanarView) { | |||
| } else if (view && view.isPlanarView) { | |||
| // TODO: make the controls accessible from PlanarView before doing | |||
There was a problem hiding this comment.
same remark here regarding the controls
There was a problem hiding this comment.
View.controls is not yet refactored between all the different type of Views.
Thes part will need to be done before we can really cahnge the TODOs in here.
ftoromanoff
force-pushed
the
reworkTestFunctional
branch
2 times, most recently
from
d04f28d to
32f7812
Compare
ftoromanoff
force-pushed
the
reworkTestFunctional
branch
from
32f7812 to
b734c9a
Compare
Desplandis
requested changes
May 6, 2024
…tion of errors and save initial camera position only once
ftoromanoff
force-pushed
the
reworkTestFunctional
branch
from
4970f66 to
9c101a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is do rewrite the functionnal test to limit the failure during githubaction linked to unclear reasons.
Changes: