Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix example Gpx 3d and functional test #2187

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

ftoromanoff
Copy link
Contributor

@ftoromanoff ftoromanoff commented Sep 13, 2023

There is a bug on the source_file_gpx_3d.html example:

  • the gpx waypoints doesn't display
  • console errors appear
    image

As the functional test wasn't well design (we only test that the view is initialized even if the example add extra layer after that), it create error in the github action from time to time.
I change the functionnal test to see if the example is fully loaded and corrected in the example the source of the error.

The error is linked to the fact that a style.fill is needed (at least in parent.style) when we instanciate a new Style:

if (typeof this.fill.pattern == 'string') {

and the way we set the getter:
return style.parent[category][name] || defaultValue;

Or in this example the style is defined during the parsing.

This issue is solve in the PR #2135 as we remove the need for a fill.patern and in PR #2006 as we remove the definition of parent Style.

@ftoromanoff ftoromanoff linked an issue Sep 13, 2023 that may be closed by this pull request
@jailln jailln requested review from AnthonyGlt and removed request for jailln September 13, 2023 09:12
test/functional/source_file_gpx_3d.js Outdated Show resolved Hide resolved
test/functional/source_file_gpx_3d.js Outdated Show resolved Hide resolved
examples/source_file_gpx_3d.html Outdated Show resolved Hide resolved
examples/source_file_gpx_3d.html Outdated Show resolved Hide resolved
@ftoromanoff ftoromanoff force-pushed the fixTestGpx branch 2 times, most recently from 85638ac to de4c85f Compare September 13, 2023 13:10
Copy link
Contributor

@AnthonyGlt AnthonyGlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this MR :)

@ftoromanoff ftoromanoff force-pushed the fixTestGpx branch 2 times, most recently from c647a64 to 450e802 Compare September 14, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug on master with the example source_file_gpx_3d
3 participants