fix example Gpx 3d and functional test #2187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug on the source_file_gpx_3d.html example:
As the functional test wasn't well design (we only test that the view is initialized even if the example add extra layer after that), it create error in the github action from time to time.
I change the functionnal test to see if the example is fully loaded and corrected in the example the source of the error.
The error is linked to the fact that a style.fill is needed (at least in parent.style) when we instanciate a new Style:
itowns/src/Core/Style.js
Line 508 in e56bf65
and the way we set the getter:
itowns/src/Core/Style.js
Line 144 in e56bf65
Or in this example the style is defined during the parsing.
This issue is solve in the PR #2135 as we remove the need for a fill.patern and in PR #2006 as we remove the definition of parent Style.