-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monorepo structure #2300
base: master
Are you sure you want to change the base?
Monorepo structure #2300
Conversation
9431214
to
e23cfef
Compare
@Desplandis I resolve some issues
|
@gchoqueux Nice! I will take a quick look of your changes and write a todo list of things that should absolutely be tested before reviewing more thoroughly this PR. Expect it for tomorrow or next tuesday! @jailln @mgermerie @ftoromanoff @AnthonyGlt I think we'll need your inputs on this change! ;) This should be a good start to fix #2197, #1930, #2201 (list not exhaustive, feel free to complete). Shall we create a meta-issue to aggregate all those issues? |
e5ec2ea
to
b2308ff
Compare
ea0116d
to
962c99d
Compare
e4fc0f5
to
80f739e
Compare
In my opinion the first thing to do is to agree together on the modules separation (i.e. on a final expected list of sub modules) and on the way / order in which it should be done to avoid going back and forth and so that anyone can contribute to this subject. We can discuss it all together in a call first if you want but I think it will need to end up in an issue eventually. WDYT? |
Yeah, I agree with @jailln and think we should start an issue/proposal where we could centralize all discussions on package splitting (use-cases, explanation of architectural/tooling changes, a sort of informal roadmap, ...). As long as we discuss those topics, I'm all in for a presentation. @ftoromanoff, @mgermerie and @AnthonyGlt, I think you should participate too. =) |
in this PR the modules follow the itowns structure
|
Ok thanks, this is fine by me. I would just rename |
|
Description
Refactoring iTowns to monorepo structure.
The goal is to split itowns down into feature packages.
As an example, I've started with the geodesy functionalities. (@itowns/geodesy)
I use lerna to watch and build packages while the dev server is in use, but I'm not completely satisfied because the files aren't supplied via memory and files are also transpiled into the browser's debugger.Lerna is also used to test packages.
exportsFields
For the moment
Debug
andWidget
modules are private.Motivation and Context
Split code in packages for clearly structured code.
Simplifies development and facilitates contributions.
Increases the scope of users who only want to use a few functions.
This structure makes it necessary to make functions independent