Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparation for PR reprojection 'a la volee' #2422

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Preparation for PR reprojection 'a la volee' #2422

merged 8 commits into from
Dec 20, 2024

Conversation

ftoromanoff
Copy link
Contributor

@ftoromanoff ftoromanoff commented Oct 2, 2024 •
edited
Loading

Following PR #2272 that became a big PR. I extracted commits that are needed for the reprojection but are also independants :

  • support of meter and foot units in crs
  • parsing crs from metadata (for entwnie and copc data)
  • few simplification or deletion of useless code

@ftoromanoff ftoromanoff force-pushed the prepAlaVolee branch 9 times, most recently from eefe617 to add66c8 Compare October 4, 2024 07:34
@ftoromanoff ftoromanoff marked this pull request as ready for review October 4, 2024 07:40
@ftoromanoff ftoromanoff requested a review from Desplandis October 4, 2024 08:41
Desplandis
Desplandis requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@Desplandis Desplandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments for this PR (mainly on proj4 patching). Could you rename the commit "supp onPointsCreated" to "delete onPointsCreated callack"?

src/Core/Geographic/Crs.js Outdated Show resolved Hide resolved
src/Core/Geographic/Crs.js Outdated Show resolved Hide resolved
src/Layer/PointCloudLayer.js Show resolved Hide resolved
src/Source/CopcSource.js Outdated Show resolved Hide resolved
src/Source/EntwinePointTileSource.js Outdated Show resolved Hide resolved
@ftoromanoff ftoromanoff force-pushed the prepAlaVolee branch 5 times, most recently from 28eca27 to b196453 Compare October 10, 2024 15:53
Desplandis
Desplandis reviewed Nov 4, 2024
View reviewed changes
test/unit/entwine.js Outdated Show resolved Hide resolved
@Desplandis Desplandis self-assigned this Dec 18, 2024
Desplandis
Desplandis approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Desplandis Desplandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the USGS datasets, sounds good to me!

@Desplandis Desplandis merged commit 8dc71f9 into iTowns:master Dec 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desplandis Desplandis Desplandis approved these changes

Assignees

@Desplandis Desplandis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ftoromanoff @Desplandis