fix(xbilparser): apply zmin / zmax for any texture subsampling size #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Min and max clamping elevation parameters were not applied when subsampling parent tile elevation texture with a window smaller that two pixels wide.
This implies that some tiles are not clamped when applying a strong zoom, like switching from the globe view to a city without animation, using STRATEGY_MIN_NETWORK_TRAFFIC. For a custom terrain, setting the usual -99999 nodata value and clamping minimum altitude to 0 results in unexpected culling removing the terrain. See the screenshot.
After looking at git history, I suppose that this might just be a coding mistake, putting these conditions in the wrong code block. What do you think @gchoqueux ?
Screenshots (if appropriate)
zoom-zmin-terrain.mp4