Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix carousel dot button's incorrect height #1921

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

FlyersPh9
Copy link
Collaborator

Changes

While working on #1919 it was discovered that the carousel's dot buttons were not getting the correct height.

  • Removed button size mixin.
  • Setting correct button height and padding values.

Testing

  • Ran visual tests.

Docs

n/a

@FlyersPh9 FlyersPh9 self-assigned this Mar 15, 2024
@FlyersPh9 FlyersPh9 requested review from a team as code owners March 15, 2024 19:14
@FlyersPh9 FlyersPh9 requested review from mayank99 and AdamMeza-Bentley and removed request for a team March 15, 2024 19:14
.changeset/rude-dolphins-hear.md Outdated Show resolved Hide resolved
@FlyersPh9 FlyersPh9 added the visual change Requires the Figma library to be updated label Mar 18, 2024
@FlyersPh9 FlyersPh9 merged commit b4a4823 into main Mar 18, 2024
16 checks passed
@FlyersPh9 FlyersPh9 deleted the jon/carousel-dot-buttons-fix branch March 18, 2024 17:12
@imodeljs-admin imodeljs-admin mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
visual change Requires the Figma library to be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants