Adds inline-size to horizontal tabs wrapper. #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ben-Pusey-Bentley
requested review from
mayank99 and
AdamMeza-Bentley
and removed request for
a team
mayank99
reviewed
Mar 26, 2024
…com/iTwin/iTwinUI into BenPusey/AddInlineSizeToTabsWrapper
mayank99
approved these changes
Mar 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds
inline-size: 100%to horizontal tabs wrappers. This change is meant to counteract an issue caused by this PR, where addingcontain: inline-sizecaused the tabs wrapper to change it's implicit width.Testing
Ran css and react visual tests to make sure that there are no unintended visual changes.
Docs
Added patch changesets to both the react and css packages.