-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ComboBox
options' tag flicking
#2120
Closed
Closed
Changes from all commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
78c44a4
Trying different approach in useOverflow
r100-stack 8c7dd69
Fixed bug causing lower than correct visibleCount.
r100-stack 0c4187a
Bug fixes. Handle resize.
r100-stack b938917
Slight code cleanup
r100-stack e41fc01
Merge remote-tracking branch 'origin/main' into r/combobox-selected-o…
r100-stack 4d42668
Tried to remove items prop. Better disabled handling.
r100-stack d09c68d
Fix infinite loop when no overflow
r100-stack c2f6b14
Update min guess when doubling.
r100-stack 8418ab0
Remove optimization for resize
r100-stack faab06e
Merge remote-tracking branch 'origin/main' into r/combobox-selected-o…
r100-stack 8467fac
Fix incorrect reset
r100-stack 6d37971
Merge remote-tracking branch 'origin/main' into r/combobox-selected-o…
r100-stack 24f5957
Left a TODO from the debugging with edge cases
r100-stack 1ac77c5
Avoid necessary reguessing on resize
r100-stack 2b70f31
Trying the component approach
r100-stack 728e62e
Working resize and tag location center
r100-stack 67dda3b
Merge remote-tracking branch 'origin/main' into r/combobox-selected-o…
r100-stack 7aafdc3
Add resize to leftover overflow examples
r100-stack ffcb17e
Bring back image tests
r100-stack c8dcc20
Merge branch 'r/overflow-add-resize-leftover' into r/combobox-selecte…
r100-stack c5789cc
Working, but…, useOverflow doesn't listen to resize.
r100-stack 7835190
Fixed the bug
r100-stack f52b103
Added `minVisibleCount` to `OverflowContainer` for `Breadcrumbs`
r100-stack 6f1acf1
Generalized calculation
r100-stack 9be9adb
Move OverflowContainer to a separate file
r100-stack 2ac3263
Merge remote-tracking branch 'origin/main' into r/combobox-selected-o…
r100-stack 017d4c3
Fix some errors
r100-stack 88b20f9
Fix imports
r100-stack 8641377
Using elements instead of refs
r100-stack 0294267
useEffect doesn't run continuously
r100-stack 6a77e1c
Working Breadcrumbs
r100-stack f738339
Cleanup
r100-stack cce04e9
Fix jumping UI in the beginning
r100-stack 063dc3f
Merge remote-tracking branch 'origin/main' into r/combobox-selected-o…
r100-stack 1581039
Easier solution than setting container from outside
r100-stack 5afb58e
Working MiddleTextTruncation
r100-stack 345d913
Working for horizontal ButtonGroup
r100-stack e692a0f
Added disabled & orientation to OverflowContainer
r100-stack e48dce7
Fixed incorrect ButtonGroup firstOverflowIndex.
r100-stack b417c5e
Working for TablePaginator
r100-stack cbf924c
Cleanup
r100-stack 8e689b9
`overflowTag` is required if children is an array
r100-stack 56612df
JSDocs
r100-stack d1e1a56
Remove unnecessary try-catch
r100-stack fc2c7fd
Removed unnecessary props from OverflowContainer
r100-stack 0dee6a3
Better disabled support
r100-stack ccdd5a8
Revert overflowButton playground changes
r100-stack f815339
WIP e2e tests
r100-stack 815d876
Revert storybook
r100-stack 2be10a1
Remove testing hooks
r100-stack 64f461e
Move useOverflow to OverflowContainer
r100-stack a96ee46
Remaining e2e tests
r100-stack bca632a
Reverted playgrounds
r100-stack 6d59b82
Resolve TODOs
r100-stack 152e52a
Resolve TODOs in OverflowContainer
r100-stack 2ad671a
Fix flaky test
r100-stack 7e529b3
Changeset
r100-stack 506dc70
Merge remote-tracking branch 'origin/main' into r/combobox-selected-o…
r100-stack 0fe9e31
Clean/Fix e2e tests
r100-stack 5c25794
Merge remote-tracking branch 'origin/main' into r/combobox-selected-o…
r100-stack eb97cbf
Set STARTING_MAX_ITEMS_COUNT = 32
r100-stack 5926d74
Cleanup
r100-stack c3e75ff
Remove unnecessary changes
r100-stack 1bca804
Moved failing unit tests to e2e
r100-stack fde3af2
Leftover failing unit tests to e2e
r100-stack f612b2f
More failing unit tests to e2e
r100-stack adbb684
Changeset and nits
r100-stack 4bc78aa
Merge remote-tracking branch 'origin/main' into r/combobox-selected-o…
r100-stack 7284b66
More explanation
r100-stack 8c0c8de
Remove unnecessary changes.
r100-stack cef8d02
Remove accidental duplicate DOM components
r100-stack 9555771
Fix failing e2e test
r100-stack bafa64b
leftover
r100-stack 10bb0a5
Fix e2e tests failing only in non-UI mode
r100-stack 164eb3a
Merge branch 'main' into r/combobox-selected-options-jittering
r100-stack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@itwin/itwinui-css': minor | ||
--- | ||
|
||
`iui-breadcrumbs-list` now stretches to the width of `iui-breadcrumbs`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@itwin/itwinui-react': patch | ||
--- | ||
|
||
Fixed a bug in `ComboBox` with `multiple` enabled where the number of tags used to keep changing in an infinite loop in certain specific container widths. As a result of this fix, the overflow behavior has been improved in other components too (e.g. `ButtonGroup`, `Breadcrumbs`, `MiddleTextTruncation`, etc.) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed this to allow the
.iui-breadcrumbs-list
'svisibleCount
to update whenever.iui-breadcrumbs
resizes.