Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resize to Breadcrumbs and ButtonGroup overflow stories #2128

Merged
merged 8 commits into from
Jul 3, 2024

Conversation

r100-stack
Copy link
Member

@r100-stack r100-stack commented Jul 3, 2024

Changes

To help me in testing useOverflow from #2120, I thought of adding resize to the overflow stories of components that use useOverflow.

Some additional improvements:

  • Initial widths try to always start the story with an overflow. Because earlier, the width was something like 50%. So, on larger screens, the story used to not overflow in the beginning.
  • Added helper text suggesting resizing the container to see the overflow behavior.
  • Moved the overflow container to decorators for cleaner story code.

Testing

  • Manually verified that the stories still look correct.
  • Changed the .test.ts files to hide the helper text and then approved the failing images.

Docs

N/A

@r100-stack r100-stack self-assigned this Jul 3, 2024
@r100-stack r100-stack marked this pull request as ready for review July 3, 2024 16:20
@r100-stack r100-stack requested review from a team as code owners July 3, 2024 16:20
@r100-stack r100-stack requested review from mayank99 and Ben-Pusey-Bentley and removed request for a team July 3, 2024 16:20
apps/react-workshop/src/ButtonGroup.stories.tsx Outdated Show resolved Hide resolved
@r100-stack r100-stack enabled auto-merge (squash) July 3, 2024 19:25
@r100-stack r100-stack merged commit 7f73ff0 into main Jul 3, 2024
16 checks passed
@r100-stack r100-stack deleted the r/button-group-overflow-example-add-resize branch July 3, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants