-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated documentation for Toast
component
#2261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68 tasks
smmr-dn
requested review from
mayank99 and
r100-stack
and removed request for
a team
September 24, 2024 20:06
mayank99
reviewed
Sep 24, 2024
r100-stack
reviewed
Sep 25, 2024
r100-stack
approved these changes
Sep 26, 2024
Co-authored-by: Rohan <[email protected]>
Co-authored-by: Uyen Doan <[email protected]> Co-authored-by: Rohan <[email protected]>
smmr-dn
commented
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in our documentation working session, I have made suggested changes to this PR:
- Combined sections that are related to status method
options
underStatus
. RewordedStatus
description to reflect more of the code, not just in plain English. - Removed unnecessary code in examples and added more examples for
order
andhasCloseButton
. - Some more re-wording.
r100-stack
approved these changes
Sep 30, 2024
mayank99
reviewed
Sep 30, 2024
mayank99
reviewed
Sep 30, 2024
mayank99
reviewed
Sep 30, 2024
mayank99
reviewed
Oct 1, 2024
mayank99
reviewed
Oct 1, 2024
mayank99
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated documentation for
Toast
component.Testing
N/A
Docs
N/A