Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation for Toast component #2261

Merged
merged 31 commits into from
Oct 1, 2024
Merged

Updated documentation for Toast component #2261

merged 31 commits into from
Oct 1, 2024

Conversation

smmr-dn
Copy link
Contributor

@smmr-dn smmr-dn commented Sep 24, 2024

Changes

Updated documentation for Toast component.

Testing

N/A

Docs

N/A

@smmr-dn smmr-dn marked this pull request as ready for review September 24, 2024 20:06
@smmr-dn smmr-dn requested a review from a team as a code owner September 24, 2024 20:06
@smmr-dn smmr-dn requested review from mayank99 and r100-stack and removed request for a team September 24, 2024 20:06
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
@mayank99 mayank99 removed their assignment Sep 27, 2024
Copy link
Contributor Author

@smmr-dn smmr-dn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in our documentation working session, I have made suggested changes to this PR:

  • Combined sections that are related to status method options under Status. Reworded Status description to reflect more of the code, not just in plain English.
  • Removed unnecessary code in examples and added more examples for order and hasCloseButton.
  • Some more re-wording.

apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
examples/Toast.close.jsx Outdated Show resolved Hide resolved
examples/Toast.placement.jsx Outdated Show resolved Hide resolved
examples/Toast.order.jsx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
apps/website/src/content/docs/toast.mdx Show resolved Hide resolved
Copy link
Contributor

@mayank99 mayank99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

apps/website/src/content/docs/toast.mdx Outdated Show resolved Hide resolved
@smmr-dn smmr-dn merged commit 090aa3d into main Oct 1, 2024
18 checks passed
@smmr-dn smmr-dn deleted the uyen/toast-doc branch October 1, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants