Allow attach/detach db to IModelDb connection #7530
+437
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aruniverse
reviewed
Jan 9, 2025
…ffanK/attach-detach-file
…ffank/attach-detach-file
…ffank/attach-detach-file
| /** | ||
| * Attach a ECDb file to this connection and load and register its schemas. | ||
| * @param fileName ECDb file name | ||
| * @param alias identifier for the attached file. This identifer is used a tablespace executing ECSQL queries. |
There was a problem hiding this comment.
I don't know what "a tablespace" is supposed to mean. Maybe you meant "as tablespace", but I don't recognize the term "tablespace". I know what this parameter does, but I don't know the proper way to describe it.
Co-authored-by: Travis Cobbs <[email protected]>
Co-authored-by: Travis Cobbs <[email protected]>
Co-authored-by: Travis Cobbs <[email protected]>
| @@ -618,7 +618,7 @@ Allow to attach a ECDb/IModel to connection and run ECSQL that combines data fro | |||
|
|
|||
| Example of attaching a snapshot to a master file and running a query that combines data from both databases: | |||
| ```ts | |||
| const master = SnapshotDb.openFile(masterFile); | |||
| const master = SnapshotDb.openFile(masterFile); | |||
There was a problem hiding this comment.
Sorry; looks like the other lines are three-space indented, while my suggested change was 4. I think the indent for all lines should be either 4 spaces or 2, but I'm not sure which is better.
There was a problem hiding this comment.
Never mind; looks like my suggested change somehow had 5 spaces, so just fix that.
| /** | ||
| * Attach a iModel file to this connection and load and register its schemas. | ||
| * @param fileName IModel file name | ||
| * @param alias identifier for the attached file. This identifer is used a tablespace executing ECSQL queries. |
There was a problem hiding this comment.
Same as for ECDb regarding "a tablespace".
tcobbs-bentley
approved these changes
Feb 20, 2025
Co-authored-by: Travis Cobbs <[email protected]>
Co-authored-by: Travis Cobbs <[email protected]>
Co-authored-by: Travis Cobbs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imodel-native: iTwin/imodel-native#956
Allow attach/detach db to active connection. This allow to combine data from more then on db using ECSQL.