Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct core-bentley imports (backport #7531) [release/4.11.x] #7645

Open
wants to merge 3 commits into
base: release/4.11.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 4, 2025

In prep for 5.0, update imports where we were previously re-exporting from core-bentley in core-common (/core/common/src/IModelError.ts)

@mergify mergify bot added the conflicts label Feb 4, 2025
Copy link
Contributor Author

mergify bot commented Feb 4, 2025

Cherry-pick of 3419be8

@mergify mergify bot requested a review from a team February 4, 2025 02:51
@aruniverse aruniverse marked this pull request as draft February 4, 2025 02:52
@tcobbs-bentley
Copy link
Member

@aruniverse Isn't this a breaking change that goes against our version policy?

@aruniverse
Copy link
Member

@aruniverse Isn't this a breaking change that goes against our version policy?

yes while this has breaking changes, we can extract some of the changes (everything but removing the re-exports) and it should be ok

@pmconne
Copy link
Member

pmconne commented Feb 5, 2025

we can extract some of the changes (everything but removing the re-exports)

What's the reason for backporting this?

@tcobbs-bentley
Copy link
Member

@aruniverse Isn't this a breaking change that goes against our version policy?

yes while this has breaking changes, we can extract some of the changes (everything but removing the re-exports) and it should be ok

If you aren't removing the re-exports, but just updating the other code not to rely on them, the title of the PR should be changed, and it should probably be explained in the description.

@aruniverse
Copy link
Member

@aruniverse Isn't this a breaking change that goes against our version policy?

yes while this has breaking changes, we can extract some of the changes (everything but removing the re-exports) and it should be ok

If you aren't removing the re-exports, but just updating the other code not to rely on them, the title of the PR should be changed, and it should probably be explained in the description.

This PR is in draft, and not ready to be reviewed. Agreed, those changes will be done prior to publishing the PR.
No changes have made since the bp pr was automatically created by the mergify bot. You should also note, the conflict label.

we can extract some of the changes (everything but removing the re-exports)

What's the reason for backporting this?

Tried updating to a 5.0 pre-release in a test app, and ran into this breaking issue. Trying to understand the blast radius and how many shared pkgs would be impacted while providing an example for other consumers prior to 5.0

@aruniverse aruniverse force-pushed the mergify/bp/release/4.11.x/pr-7531 branch from d4fd42f to 08c5092 Compare February 10, 2025 22:17
@aruniverse aruniverse changed the title Remove re-export of core-bentley apis in core-common (backport #7531) [release/4.11.x] correct core-common imports (backport #7531) [release/4.11.x] Feb 10, 2025
@aruniverse aruniverse changed the title correct core-common imports (backport #7531) [release/4.11.x] correct core-bentley imports (backport #7531) [release/4.11.x] Feb 10, 2025
@aruniverse aruniverse marked this pull request as ready for review February 10, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants