Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Eslint & Typescript #753

Merged
merged 15 commits into from
Oct 28, 2024
Merged

Bump Eslint & Typescript #753

merged 15 commits into from
Oct 28, 2024

Conversation

saskliutas
Copy link
Member

Closes #745
Closes #744

@saskliutas saskliutas requested a review from a team as a code owner October 25, 2024 12:57
Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 70d2e3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

github-actions bot commented Oct 25, 2024

Unified selection benchmark

Benchmark suite Current: 70d2e3e Previous: 24c6553 Deviation Status
hilite 50k elements 1175.66 ms 1169.71 ms 0.5087% 🚨
hilite 50k elements (P95 of main thread blocks) 42 ms 40 ms 5% 🚨
hilite 50k group elements 236.3 ms 240.72 ms -1.8362%
hilite 50k group elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
hilite 1k subjects 44761.75 ms 44919.59 ms -0.3514%
hilite 1k subjects (P95 of main thread blocks) 28 ms 30 ms -6.6667%
hilite 50k subcategories 274.97 ms 272.08 ms 1.0622% 🚨
hilite 50k subcategories (P95 of main thread blocks) 32 ms 33 ms -3.0303%
hilite 50k functional 3D elements 25225.54 ms 25386.87 ms -0.6355%
hilite 50k functional 3D elements (P95 of main thread blocks) 34 ms 40 ms -15%
hilite 50k functional 2D elements 6019.09 ms 5950.12 ms 1.1591% 🚨
hilite 50k functional 2D elements (P95 of main thread blocks) 34 ms 40 ms -15%
compute selection for 50k elements 301.87 ms 305.85 ms -1.3013%
compute selection for 50k elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute parent selection for 50k elements 335.54 ms 332.77 ms 0.8324% 🚨
compute parent selection for 50k elements (P95 of main thread blocks) 32 ms 31 ms 3.2258% 🚨
compute top ancestor selection for 50k elements 562.06 ms 560.7 ms 0.2426% 🚨
compute top ancestor selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute category selection for 50k elements 92.39 ms 89 ms 3.8090% 🚨
compute category selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute model selection for 50k elements 73.74 ms 76.98 ms -4.2089%
compute model selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 3D elements 403.15 ms 430.82 ms -6.4226%
compute functional selection for 50k 3D elements (P95 of main thread blocks) 31 ms 38 ms -18.4211%
compute parent functional selection for 50k 3D elements 434.45 ms 442.78 ms -1.8813%
compute parent functional selection for 50k 3D elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute top ancestor functional selection for 50k 3D elements 1124.4 ms 1139.24 ms -1.3026%
compute top ancestor functional selection for 50k 3D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 2D elements 2941.4 ms 2972.78 ms -1.0556%
compute functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute parent functional selection for 50k 2D elements 2947.68 ms 3022.42 ms -2.4729%
compute parent functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute top ancestor functional selection for 50k 2D elements 3007.41 ms 3031.04 ms -0.7796%
compute top ancestor functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

github-actions bot commented Oct 25, 2024

Hierarchies benchmark

Benchmark suite Current: 70d2e3e Previous: 033beb4 Deviation Status
flat 50k elements list 4787.8 ms 4730.19 ms 1.2179% 🚨
flat 50k elements list (P95 of main thread blocks) 77 ms 73 ms 5.4795% 🚨
filtering filters with 50000 paths 13916.03 ms 13668.22 ms 1.8130% 🚨
filtering filters with 50000 paths (P95 of main thread blocks) 128 ms 137 ms -6.5693%
grouping by label 10952.64 ms 10573.84 ms 3.5824% 🚨
grouping by label (P95 of main thread blocks) 73 ms 68 ms 7.3529% 🚨
grouping by class 10946.09 ms 10691.36 ms 2.3826% 🚨
grouping by class (P95 of main thread blocks) 47 ms 45 ms 4.4444% 🚨
grouping by property 11673.87 ms 11383.15 ms 2.5540% 🚨
grouping by property (P95 of main thread blocks) 62 ms 56 ms 10.7143% 🚨
grouping by base class (10 classes) 8412.94 ms 7849.35 ms 7.1801% 🚨
grouping by base class (10 classes) (P95 of main thread blocks) 72 ms 73 ms -1.3699%
grouping by multiple attributes 28924.35 ms 28272.55 ms 2.3054% 🚨
grouping by multiple attributes (P95 of main thread blocks) 44 ms 43 ms 2.3256% 🚨
hide if no children required to finalize root, w/o children 56366.43 ms 49902.85 ms 12.9523% 🚨
hide if no children required to finalize root, w/o children (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
hide if no children required to finalize root, w/ children 186.14 ms 179.05 ms 3.9598% 🚨
hide if no children required to finalize root, w/ children (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree initial (Baytown) 44.01 ms 39.04 ms 12.7305% 🚨
models tree initial (Baytown) (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree full (Baytown) 7835.66 ms 7720.99 ms 1.4852% 🚨
models tree full (Baytown) (P95 of main thread blocks) 88 ms 86 ms 2.3256% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@saskliutas saskliutas merged commit 7f35490 into master Oct 28, 2024
12 checks passed
@saskliutas saskliutas deleted the eslint-bump branch October 28, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to TS 5.6 Upgrade ESLint to version 9
2 participants