Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote beta APIs #758

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Promote beta APIs #758

merged 3 commits into from
Oct 30, 2024

Conversation

grigasp
Copy link
Member

@grigasp grigasp commented Oct 29, 2024

Closes #757

@grigasp grigasp requested a review from a team as a code owner October 29, 2024 19:13
Copy link

changeset-bot bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: 2248128

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@itwin/presentation-hierarchies-react Patch
@itwin/unified-selection Patch
@itwin/presentation-core-interop Patch
@itwin/presentation-hierarchies Patch
@itwin/presentation-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@grigasp grigasp enabled auto-merge (squash) October 29, 2024 19:14
Copy link

github-actions bot commented Oct 29, 2024

Unified selection benchmark

Benchmark suite Current: 2248128 Previous: 74f7f40 Deviation Status
hilite 50k elements 1245.25 ms 1348.71 ms -7.6710%
hilite 50k elements (P95 of main thread blocks) 42 ms 47 ms -10.6383%
hilite 50k group elements 237.38 ms 245.38 ms -3.2602%
hilite 50k group elements (P95 of main thread blocks) 34 ms 33 ms 3.0303% 🚨
hilite 1k subjects 45209.01 ms 45341.46 ms -0.2921%
hilite 1k subjects (P95 of main thread blocks) 30 ms 30 ms 0% 🟰
hilite 50k subcategories 277.02 ms 297.39 ms -6.8496%
hilite 50k subcategories (P95 of main thread blocks) 33 ms 33 ms 0% 🟰
hilite 50k functional 3D elements 25790.85 ms 25830.26 ms -0.1526%
hilite 50k functional 3D elements (P95 of main thread blocks) 37 ms 40 ms -7.5000%
hilite 50k functional 2D elements 6169.73 ms 6379.31 ms -3.2853%
hilite 50k functional 2D elements (P95 of main thread blocks) 38 ms 42 ms -9.5238%
compute selection for 50k elements 338.45 ms 320.08 ms 5.7392% 🚨
compute selection for 50k elements (P95 of main thread blocks) 35 ms 32 ms 9.3750% 🚨
compute parent selection for 50k elements 344.6 ms 378.72 ms -9.0093%
compute parent selection for 50k elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute top ancestor selection for 50k elements 560.35 ms 585.91 ms -4.3624%
compute top ancestor selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute category selection for 50k elements 92.53 ms 93.45 ms -0.9845%
compute category selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute model selection for 50k elements 77.28 ms 78.5 ms -1.5541%
compute model selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 3D elements 415.36 ms 424.99 ms -2.2659%
compute functional selection for 50k 3D elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute parent functional selection for 50k 3D elements 453.96 ms 498.28 ms -8.8946%
compute parent functional selection for 50k 3D elements (P95 of main thread blocks) 34 ms 31 ms 9.6774% 🚨
compute top ancestor functional selection for 50k 3D elements 1147.8 ms 1278.28 ms -10.2075%
compute top ancestor functional selection for 50k 3D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 2D elements 3147.55 ms 3353.34 ms -6.1369%
compute functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute parent functional selection for 50k 2D elements 3042.03 ms 3215.74 ms -5.4019%
compute parent functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute top ancestor functional selection for 50k 2D elements 3155.03 ms 3385.16 ms -6.7982%
compute top ancestor functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

github-actions bot commented Oct 29, 2024

Hierarchies benchmark

Benchmark suite Current: 2248128 Previous: 74f7f40 Deviation Status
flat 50k elements list 4647.58 ms 4832.2 ms -3.8206%
flat 50k elements list (P95 of main thread blocks) 74 ms 77 ms -3.8961%
filtering filters with 50000 paths 14246.84 ms 14184.3 ms 0.4409% 🚨
filtering filters with 50000 paths (P95 of main thread blocks) 145 ms 131 ms 10.6870% 🚨
grouping by label 11024.05 ms 11119.94 ms -0.8623%
grouping by label (P95 of main thread blocks) 66 ms 72 ms -8.3333%
grouping by class 10968.33 ms 11306.28 ms -2.9890%
grouping by class (P95 of main thread blocks) 39 ms 44 ms -11.3636%
grouping by property 11652.09 ms 11795.55 ms -1.2162%
grouping by property (P95 of main thread blocks) 55 ms 61 ms -9.8361%
grouping by base class (10 classes) 8189.52 ms 8303.05 ms -1.3673%
grouping by base class (10 classes) (P95 of main thread blocks) 75 ms 64 ms 17.1875% 🚨
grouping by multiple attributes 28990.87 ms 29403.45 ms -1.4032%
grouping by multiple attributes (P95 of main thread blocks) 44 ms 48 ms -8.3333%
hide if no children required to finalize root, w/o children 51997.7 ms 51376.7 ms 1.2087% 🚨
hide if no children required to finalize root, w/o children (P95 of main thread blocks) 31 ms 30 ms 3.3333% 🚨
hide if no children required to finalize root, w/ children 174.32 ms 190.37 ms -8.4310%
hide if no children required to finalize root, w/ children (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree initial (Baytown) 39.71 ms 43.27 ms -8.2274%
models tree initial (Baytown) (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree full (Baytown) 7825.38 ms 7880.15 ms -0.6950%
models tree full (Baytown) (P95 of main thread blocks) 91 ms 89 ms 2.2472% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@grigasp grigasp merged commit 745cef4 into master Oct 30, 2024
10 checks passed
@grigasp grigasp deleted the promote-apis branch October 30, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote APIs in new 1.0 packages to @public
2 participants