Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce main thread blocking when filtering Models tree #798

Merged
merged 8 commits into from
Dec 18, 2024

Conversation

JonasDov
Copy link
Contributor

@JonasDov JonasDov commented Dec 10, 2024

Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 0a8d33f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JonasDov JonasDov marked this pull request as ready for review December 16, 2024 10:14
@JonasDov JonasDov requested a review from a team as a code owner December 16, 2024 10:14
Copy link

github-actions bot commented Dec 16, 2024

Hierarchies benchmark

Benchmark suite Current: 0a8d33f Previous: b8079df Deviation Status
flat 50k elements list 4792.04 ms 4774.35 ms 0.3705% 🚨
flat 50k elements list (P95 of main thread blocks) 78 ms 76 ms 2.6316% 🚨
filtering filters with 50000 paths 10745.48 ms 10626.69 ms 1.1178% 🚨
filtering filters with 50000 paths (P95 of main thread blocks) 114 ms 123 ms -7.3171%
grouping by label 11295.59 ms 11160.79 ms 1.2078% 🚨
grouping by label (P95 of main thread blocks) 71 ms 73 ms -2.7397%
grouping by class 11358.47 ms 11221.13 ms 1.2239% 🚨
grouping by class (P95 of main thread blocks) 39 ms 51 ms -23.5294%
grouping by property 11858.19 ms 11956.23 ms -0.8200%
grouping by property (P95 of main thread blocks) 82 ms 57 ms 43.8596% 🚨
grouping by base class (10 classes) 8783.33 ms 9135.23 ms -3.8521%
grouping by base class (10 classes) (P95 of main thread blocks) 68 ms 69 ms -1.4493%
grouping by multiple attributes 29893.83 ms 29757.74 ms 0.4573% 🚨
grouping by multiple attributes (P95 of main thread blocks) 40 ms 55 ms -27.2727%
hide if no children required to finalize root, w/o children 55973.43 ms 52754.57 ms 6.1016% 🚨
hide if no children required to finalize root, w/o children (P95 of main thread blocks) 30 ms 43 ms -30.2326%
hide if no children required to finalize root, w/ children 171.86 ms 179.49 ms -4.2509%
hide if no children required to finalize root, w/ children (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree initial (Baytown) 43.28 ms 41.7 ms 3.7890% 🚨
models tree initial (Baytown) (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree full (Baytown) 8496.95 ms 8528.09 ms -0.3651%
models tree full (Baytown) (P95 of main thread blocks) 86 ms 85 ms 1.1765% 🚨
models tree creates initial filtered view for 50k target items 2242.69 ms 2306.25 ms -2.7560%
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) 104 ms 288 ms -63.8889%

This comment was automatically generated by workflow using github-action-benchmark.

@JonasDov JonasDov linked an issue Dec 16, 2024 that may be closed by this pull request
@grigasp grigasp changed the title Update performance Reduce main thread blocking when filtering Models tree Dec 18, 2024
@JonasDov JonasDov merged commit 100f4bb into master Dec 18, 2024
9 checks passed
@JonasDov JonasDov deleted the JonasD/performance branch December 18, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtered models tree initial view causes main thread blocking
2 participants