refactor: allow dependency injection of httpClient #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the GuzzleHttp Client was created inside the Request helper which it self was instanciated in the Client. This made it impossible to dependency inject a http Client of my own choosing. While making DI possible I opted for removing the Request class entirely as it wasn’t creating much value.
silvav
reviewed
Oct 20, 2019
| * @throws HeapException | ||
| * @throws GuzzleException |
There was a problem hiding this comment.
Within this scope I see HeapException being thrown.
Why GuzzleException has been added to the doc block?
silvav
reviewed
Oct 20, 2019
| @@ -2,22 +2,43 @@ | |||
|
|
|||
| namespace Heap; | |||
|
|
|||
| use GuzzleHttp\ClientInterface; | |||
There was a problem hiding this comment.
What do you think about adding support for PSR-18 and using its ClientInterface?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the GuzzleHttp Client was created inside the Request helper which it self was instanciated in the Client. This made it impossible to dependency inject a http Client of my own choosing.
While making DI possible I opted for removing the Request class entirely as it wasn’t creating much value.