Skip to content

Conversation

MaAbt
Copy link

@MaAbt MaAbt commented Oct 4, 2018

No description provided.

MaAbt added 2 commits October 4, 2018 14:57
Add qtcsv.pro File for easier inclusion in QBS based Projects
Built as staticlibrary
Add qtcsv.pro for QBS project inclusion
@iamantony
Copy link
Owner

Hello, @MaAbt !

Thanks for your contribution!

Well, I never used .qbs files so I don't know much about them. But I have a few comments:

  • in .qbs file you set that we build static lib, but qtcsv by default is shared lib. Could you add a commented command or a special flag that would switch build type from shared to static? (Examples: qtcsv.pro, CMakeLists.txt). And also QTCSV_STATIC_LIB define should be added only in case of building of static lib.
  • qtcsv do not requires C++11
  • could you add a version of qtcsv?
  • could you add compiler flags for gcc? (Example: CMakeLists.txt)
  • could you add installation command?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants