Etsy client not usable thread-safely with multiple API keys

[Muon]

Using multiple API credentials with the client is currently impossible to do thread-safely since everything is in the global module. I propose creating an Etsy::Client class, like the Twitter gem's Twitter::Client. This would permit creating separate instances of it for the multi-key use case, and an instance of it could be stuffed in the module to keep backwards compatibility.

[kytrinyx]

Something like this?

client = Etsy::Client.new(:api_key => 'key', :secret  => 'secret', :environment => :production)

client.get '/taxonomy/tags', :limit => 5

[Muon]

Sort of, but also including the methods currently accessible through the module interface like:

client = Etsy::Client.new(:api_key => 'key', :secret  => 'secret', :environment => :production)

client.user('littletjane')

[orendon]

hi, any plans to include this in further releases?

[kytrinyx]

Nobody tested the branch, so I didn't want to release it. I don't have any etsy apps anymore, so I can't really test it against any sort of real usage, and I don't want to inadvertently break people's production apps.

[trobrock]

Same for myself, I'm not actively using the etsy api myself so we were just waiting on some regression testing.