Move to Faraday #24

trobrock · 2012-07-19T15:08:48Z

Currently, the gem is doing a lot of the HTTP work on its own, which might not be such a good idea (e.g. issue #23). Moving to Faraday would also take a good chunk out of the test code, and permit easier future extension. Thoughts and opinions?

reagent · 2012-02-20T14:12:16Z

I want to minimize the number of external dependencies this gem has, which is why I went the net/http route in the beginning. With your patch to #23, there shouldn't be much need for these other dependencies -- are there other issues that would be resolved by adding one of these gems?

Muon · 2012-02-20T14:23:52Z

I should think that the lack of error detection and handling and write support could be much more easily remedied with Faraday. Also, parallel requests could be easily integrated with the Typhoeus adapter.

Muon · 2012-03-01T09:20:07Z

One more point for Faraday: the JSON parsing middleware doesn't seem to have any Rails-related bugs.

trobrock · 2012-07-03T23:24:32Z

I'd be interested in seeing what the spike of this would look like, have you done any work towards this to see how involved it would be?

kytrinyx · 2012-07-04T05:36:55Z

+1, I'd also be interested in seeing a spike on this.

Muon · 2012-07-04T11:05:59Z

Sorry, nothing yet. Should be pretty simple though.

…el methods here and replacing complicated Net::HTTP logic with Faraday

I know two test suites right now, but it'll get better…

…different across platforms

trobrock · 2012-07-17T23:30:27Z

I'm spiking on a new version of the gem, this include a client class like mentioned in #29 and using Faraday. Its on the faraday branch if you are interested. https://github.com/kytrinyx/etsy/tree/faraday

Conflicts: etsy.gemspec

kytrinyx · 2012-07-18T11:58:20Z

I really like this direction. I'll jump in tomorrow and add the pieces for authenticated requests.

Muon · 2012-07-18T12:26:13Z

Seconded. I'll see if I can find a bit of time to help with this.

kytrinyx · 2012-07-18T13:03:29Z

I'm looking at the VCR / API key things for testing, and wondering how to best set up tests for an authenticated user. We can use ENV variables so that each developer keeps track of their own API key, but what about having a test user and test shop?

I could write specs against my own user, but I don't want to commit expected results to the repo. We could filter out the sensitive data in the same way that we filter out the API key, but then you couldn't delete the cassettes without knowing how to log in as me.

Should we create a fake user and share the login amongst us? (not a very tempting proposition).

Any suggestions?

trobrock · 2012-07-18T15:08:12Z

The way I've been doing it is filling in my own API key in the
api_credentials.rb file and VCR will auto filter out things defined as a
constant in those files, just don't commit the one file.
On Jul 18, 2012 6:03 AM, "Katrina Owen" <
[email protected]>
wrote:

I'm looking at the VCR / API key things for testing, and wondering how
to best set up tests for an authenticated user. We can use ENV variables
so that each developer keeps track of their own API key, but what about
having a test user and test shop?

I could write specs against my own user, but I don't want to commit
expected results to the repo. We could filter out the sensitive data in the
same way that we filter out the API key, but then you couldn't delete the
cassettes without knowing how to log in as me.

Should we create a fake user and share the login amongst us? (not a very
tempting proposition).

Any suggestions?

Reply to this email directly or view it on GitHub:
#24 (comment)

trobrock · 2012-07-18T17:58:24Z

If that doesn't make sense let me know

kytrinyx · 2012-07-18T18:01:20Z

It makes sense, but I'd rather not have to remember not to commit a change to a file that is already in source control. I'd rather export SOME_CONSTANT in .bash_profile and then ENV.fetch("SOME_CONSTANT") in the code.

michaelficarra · 2012-07-18T18:09:31Z

No need to export. SOME_CONSTANT=secret ruby myprogram.rb.

trobrock · 2012-07-18T18:25:00Z

I'll push a change in a few minutes for the env variables
On Jul 18, 2012 11:09 AM, "Michael Ficarra" <
[email protected]>
wrote:

No need to export. SOME_CONSTANT=secret ruby myprogram.rb.

Reply to this email directly or view it on GitHub:
#24 (comment)

trobrock · 2012-07-18T18:37:15Z

What do you think about this: 31d128b

kytrinyx · 2012-07-18T19:39:51Z

Oh, nice!

kytrinyx · 2012-07-21T11:10:06Z

@Muon do you see a need for a single Etsy::Client instance that could work with separate oauth credentials? If so, what would you want that to look like? A Credentials object that can be passed to the Client instance along with the call?

Muon · 2012-07-21T13:08:32Z

No, no, this is fine. I was merely confused since there were attr_accessors defined for oauth_token and oauth_secret. So should they be removed, or at least replaced with attr_readers?

trobrock · 2012-07-21T17:09:14Z

Right now the way it works is a bit weird you have to use the access token
method to get the keys and then you have to set them on the client class
via the attr_accessors.
On Jul 21, 2012 6:08 AM, "Mak Nazečić-Andrlon" <
[email protected]>
wrote:

No, no, this is fine. I was merely confused since there were
attr_accessors defined for oauth_token and oauth_secret. So should
they be removed, or at least replaced with attr_readers?

Reply to this email directly or view it on GitHub:
#24 (comment)

kytrinyx · 2012-07-21T17:47:25Z

Basically there are a couple ways this would be used.

Create a client, do the oauth dance, and continue using the client
Initialize the client with the oauth token/secret

It might make sense to save the oauth token into instance variables when they're received and only have attr_readers, like @Muon suggested.

trobrock · 2012-07-21T17:57:13Z

I agree
On Jul 21, 2012 10:47 AM, "Katrina Owen" <
[email protected]>
wrote:

Basically there are a couple ways this would be used.

Create a client, do the oauth dance, and continue using the client

Initialize the client with the oauth token/secret

It might make sense to save the oauth token into instance variables when
they're received and only have attr_readers, like @Muon suggested.

Reply to this email directly or view it on GitHub:
#24 (comment)

travisbot · 2012-08-21T18:57:52Z

This pull request fails (merged f5f2370 into 04416c2).

travisbot · 2012-08-21T19:04:59Z

This pull request passes (merged 0c5074b into 04416c2).

trobrock · 2012-08-21T19:49:38Z

@kytrinyx what's left to do here, sorry been a bit disconnected lately
On Aug 21, 2012 12:05 PM, "The Travis Bot" [email protected] wrote:

This pull request passeshttp://travis-ci.org/kytrinyx/etsy/builds/2192393(merged
0c5074b 0c5074b0 into 04416c204416c2c
).

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/24#issuecomment-7912263.

kytrinyx · 2012-08-22T05:48:34Z

@trobrock I think the only thing left is to add support for nested resources:

Finally, associations can be nested up to three levels deep, using slashes:
/v2/listings/active?includes=Shop/User
/v2/shops/etsystore?includes=Listings:1:0/Images

travisbot · 2012-08-22T19:24:31Z

This pull request passes (merged 3e20b95 into 04416c2).

kytrinyx · 2012-08-22T19:31:04Z

@trobrock I've added the nested resources syntax to the query.

If this all looks good, I'd suggest that we merge this in, deprecate the model stuff (but not rip it out yet), and bump the version to 0.3.0. Then when we're ready to remove the older syntax we can bump to 1.0.0.

Would you have time over the next week or so to take the query syntax for a spin?

trobrock · 2012-08-23T00:20:54Z

Looks good to me, I will try this week or next to test out the syntax. I agree with the idea of one release with a deprecation, then completely remove it.

* master: #53: add bought listings to user pass credentials #51: find admirers Inline the Etsy.host parameter in BasicClient add Roger Smith to README add more attributes to listing add more attributes to listing ability to create a favorite listing ability to create a favorite listing add buyer_id to transactions should be users/ not listings/ adding ability to retrieve a user's favorite listings Updating rake dependency for upcoming 0.9.3 release

When running the specs on jruby, srand is initialized incorrectly. Downgrading to rspec 2.7.x allows the specs to be run.

trobrock added 11 commits July 11, 2012 14:41

Script to use custom api keys without having to commit them

c17bdba

Start of an Etsy::Client class beginning to implement Etsy module lev…

6c21440

…el methods here and replacing complicated Net::HTTP logic with Faraday

Changing Rakefile output a little

63bfe73

Make specs run in default task also

cbdf30b

I know two test suites right now, but it'll get better…

Adding SimpleCov coverage

c256775

Merge branch 'master' of github.com:kytrinyx/etsy into faraday

3b9ce64

Fix failure from jruby, need openssl gem

fb21554

Match requests on parsed query strings rather than URI, which can be …

ae71d9a

…different across platforms

Turn of simplecov in travis to avoid issues with 1.9 mode on rbx

58a89e5

Use VCR's builtin filtering for keys

fef0edd

Remove credentials file from ignore

49c9bbf

Merge branch 'master' of github.com:kytrinyx/etsy into faraday

e2d71aa

Conflicts: etsy.gemspec

Pattern for using ENV variables for keys

31d128b

kytrinyx added 8 commits July 26, 2012 13:03

Implement basic query object.

2aa220f

Deliver params and endpoint separately in query.

5b36d1c

Wrap hashes in curly braces

bb7512c

Remove to_s override on query

93c0702

Add rudimentary support for associations in query.

7c27be5

Add support for arbitrary query parameters.

07b71c0

Tweak syntax for specifying resources in query

fcf1c17

Add basic query syntax for associated resources

f5f2370

Add spec helper to query and resource specs

0c5074b

Add nested resources

3e20b95

kytrinyx and others added 6 commits September 23, 2012 14:47

Downgrade rspec.

a947cd4

When running the specs on jruby, srand is initialized incorrectly. Downgrading to rspec 2.7.x allows the specs to be run.

Add link to JRuby issue

d29fb09

Add spec for method missing

ebcab8a

Merge branch 'master' into faraday

5de051f

fixed broken rspec, may cause problems with jruby

51d75ea

trobrock closed this Jul 5, 2020

trobrock deleted the faraday branch July 5, 2020 11:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move to Faraday #24

Move to Faraday #24

trobrock commented Jul 19, 2012

reagent commented Feb 20, 2012

Muon commented Feb 20, 2012

Muon commented Mar 1, 2012

trobrock commented Jul 3, 2012

kytrinyx commented Jul 4, 2012

Muon commented Jul 4, 2012

trobrock commented Jul 17, 2012

kytrinyx commented Jul 18, 2012

Muon commented Jul 18, 2012

kytrinyx commented Jul 18, 2012

trobrock commented Jul 18, 2012

trobrock commented Jul 18, 2012

kytrinyx commented Jul 18, 2012

michaelficarra commented Jul 18, 2012

trobrock commented Jul 18, 2012

trobrock commented Jul 18, 2012

kytrinyx commented Jul 18, 2012

kytrinyx commented Jul 21, 2012

Muon commented Jul 21, 2012

trobrock commented Jul 21, 2012

kytrinyx commented Jul 21, 2012

trobrock commented Jul 21, 2012

travisbot commented Aug 21, 2012

travisbot commented Aug 21, 2012

trobrock commented Aug 21, 2012

kytrinyx commented Aug 22, 2012

travisbot commented Aug 22, 2012

kytrinyx commented Aug 22, 2012

trobrock commented Aug 23, 2012

Move to Faraday #24

Move to Faraday #24

Conversation

trobrock commented Jul 19, 2012

reagent commented Feb 20, 2012

Muon commented Feb 20, 2012

Muon commented Mar 1, 2012

trobrock commented Jul 3, 2012

kytrinyx commented Jul 4, 2012

Muon commented Jul 4, 2012

trobrock commented Jul 17, 2012

kytrinyx commented Jul 18, 2012

Muon commented Jul 18, 2012

kytrinyx commented Jul 18, 2012

trobrock commented Jul 18, 2012

trobrock commented Jul 18, 2012

kytrinyx commented Jul 18, 2012

michaelficarra commented Jul 18, 2012

trobrock commented Jul 18, 2012

trobrock commented Jul 18, 2012

kytrinyx commented Jul 18, 2012

kytrinyx commented Jul 21, 2012

Muon commented Jul 21, 2012

trobrock commented Jul 21, 2012

kytrinyx commented Jul 21, 2012

trobrock commented Jul 21, 2012

travisbot commented Aug 21, 2012

travisbot commented Aug 21, 2012

trobrock commented Aug 21, 2012

kytrinyx commented Aug 22, 2012

travisbot commented Aug 22, 2012

kytrinyx commented Aug 22, 2012

trobrock commented Aug 23, 2012