Skip to content

fix _get() params. add test for find_by_status() #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix _get() params. add test for find_by_status() #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iamport/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def _delete(self, url):

def find_by_status(self, status, **params):
url = '{}payments/status/{}'.format(self.imp_url, status)
return self._get(url, params=params)
return self._get(url, payload=params)

def find_by_merchant_uid(self, merchant_uid, status=None):
url = '{}payments/find/{}'.format(self.imp_url, merchant_uid)
Expand Down
3 changes: 3 additions & 0 deletions tests/test_find_with_status.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@ def test_find_with_status(iamport):

res = iamport.find_by_merchant_uid(merchant_uid='1234qwer', status='paid')
assert res['merchant_uid'] == '1234qwer'

res = iamport.find_by_status(status='paid', payload={'page':'4',})
assert res['total'] != 0