Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scratch image #439

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Add scratch image #439

merged 2 commits into from
Apr 26, 2024

Conversation

HansK-p
Copy link
Contributor

@HansK-p HansK-p commented Apr 22, 2024

Description

This change adds support for the Scratch image. Docker image sizes after a make docker:

iamseth/oracledb_exporter                      0.6.0-oraclelinux_legacy-tablespace   25f1e02b4c1b   6 minutes ago    137MB
iamseth/oracledb_exporter                      0.6.0-oraclelinux                     4e01e343f297   6 minutes ago    137MB
iamseth/oracledb_exporter                      oraclelinux                           4e01e343f297   6 minutes ago    137MB
iamseth/oracledb_exporter                      0.6.0-alpine                          356dfb18f4a0   7 minutes ago    33.2MB
iamseth/oracledb_exporter                      alpine                                356dfb18f4a0   7 minutes ago    33.2MB
iamseth/oracledb_exporter                      0.6.0-alpine_legacy-tablespace        26d2523cd997   7 minutes ago    33.2MB
iamseth/oracledb_exporter                      0.6.0_legacy-tablespace               a76344c6e1f9   7 minutes ago    102MB
iamseth/oracledb_exporter                      0.6.0                                 504e59108b9c   7 minutes ago    102MB
iamseth/oracledb_exporter                      latest                                504e59108b9c   7 minutes ago    102MB
iamseth/oracledb_exporter                      0.6.0-scratch_legacy-tablespace       ccb9b08fa21e   22 minutes ago   25.7MB
iamseth/oracledb_exporter                      0.6.0-scratch                         7107a78ffd8a   22 minutes ago   25.7MB
iamseth/oracledb_exporter                      scratch                               7107a78ffd8a   22 minutes ago   25.7MB

Fixes #438

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

The following was executed in order to test the change

make scratch-image
docker run iamseth/oracledb_exporter:scratch

In additon we have used the image internally for a few days, but with CA and TZ info included. This is mostly as we are running monitoring where TZ info most probably is a requiremt. This has not been validated.

Screenshots (if appropriate):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Updated version in Makefile respecting semver v2

@Yannig Yannig merged commit 990596d into iamseth:master Apr 26, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish Docker images based on the "scratch" base image
2 participants