Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for iamseth/oracledb_exporter#459 #460

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Fix for iamseth/oracledb_exporter#459 #460

merged 2 commits into from
Jul 29, 2024

Conversation

valrusu
Copy link
Contributor

@valrusu valrusu commented Jul 2, 2024

Description

Fixes # 459

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran this version for 3 weeks for 36 databases

Screenshots (if appropriate):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Updated version in Makefile respecting semver v2

@HansK-p HansK-p mentioned this pull request Jul 14, 2024
Open
@valrusu valrusu mentioned this pull request Jul 24, 2024
Closed
@Yannig Yannig merged commit 6ab50a9 into iamseth:master Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valrusu @Yannig