Add the ability to broadcast the discovery query on a different IP. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f you're on a network with muliple subnets, then 255.255.255.255 will not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I love your pyharmony client, and I've built a part of my home automation project around it. Thanks so much for the work you've done!
In a newer version you introduced the ability to discover the Harmony Hub, rather than having to hard-code the IP and port. A real neat feature, but unfortunately if you're on a network with multiple subnets, then 255.255.255.255 will not work. So I've added the option to provide a different broadcast IP, and then it works perfectly on my network too.
It's my first pull-request on GitHub, I hope this is useful for your project!